Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate INP #169

Merged
merged 7 commits into from
Feb 22, 2024
Merged

Graduate INP #169

merged 7 commits into from
Feb 22, 2024

Conversation

rviscomi
Copy link
Member

@rviscomi rviscomi commented Jan 28, 2024 •
edited
Loading

HUD

image

Popup

image

Status bar

image

tunetheweb
tunetheweb requested changes Jan 28, 2024
View reviewed changes
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annoyingly our docs are available with final slash and without. Without is preferred as that's what internal links use.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
manifest.json Show resolved Hide resolved
package.json Show resolved Hide resolved
@tunetheweb tunetheweb mentioned this pull request Jan 28, 2024
Merged
rviscomi and others added 3 commits January 28, 2024 08:26
@rviscomi @tunetheweb
Apply suggestions from code review
d1d48de 
Co-authored-by: Barry Pollard <barrypollard@google.com>
@rviscomi
swap INP/FID in HUD
f3a272d
@rviscomi
slow INP icon
6a7535a
@rviscomi rviscomi marked this pull request as ready for review February 22, 2024 13:20
tunetheweb
tunetheweb reviewed Feb 22, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/browser_action/metric.js Outdated Show resolved Hide resolved
src/browser_action/popup.html Outdated Show resolved Hide resolved
src/browser_action/popup.js Show resolved Hide resolved
src/browser_action/vitals.js Show resolved Hide resolved
@rviscomi @tunetheweb
Apply suggestions from code review
244ca3c 
Co-authored-by: Barry Pollard <barrypollard@google.com>
@tunetheweb tunetheweb mentioned this pull request Feb 22, 2024
Merged
tunetheweb
tunetheweb approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update images in README? Other than that good to merge.

@rviscomi
Copy link
Member Author

Regenerating screenshots for the README

@rviscomi
Copy link
Member Author

Jinx

@rviscomi rviscomi merged commit 2082064 into main Feb 22, 2024
3 checks passed
@rviscomi rviscomi deleted the graduate-inp branch February 22, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tunetheweb tunetheweb tunetheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rviscomi @tunetheweb