Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reestablish message port on bfcache restore #172

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

tunetheweb
Copy link
Member

As per: https://developer.chrome.com/blog/bfcache-extension-messaging-changes we need to add some extra code for bfcache restores for future breaking changes in Chrome.

See also #161 (comment)

To repeat without this fix:

  • Launch Chrome >= 123 with --enable-features=DisconnectExtensionMessagePortWhenPageEntersBFCache
  • Install the extension
  • Pin it to extension bar
  • Go to https://www.tunetheweb.com/experiments/softnavsdemo/#1
  • Note Green circle badge
  • Click "Simulate slow interaction"
  • Note badge changes to red triangle
  • Reload to reset back to Green Circle
  • Go to https://www.example.com/
  • Go back to restore from bfcache
  • Note badge stays at grey 馃様
  • Click "Simulate slow interaction"
  • Note badge stays at grey 馃様

Use this branch, and repeat above test, and note last two 馃様 are now 馃榿

FYI: @lozy219 @oliverdunk

@tunetheweb tunetheweb merged commit fbbfcdf into main Mar 5, 2024
3 checks passed
@rviscomi rviscomi deleted the reestablish-message-port-on-bfcache-restore branch March 5, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants