fix: end animations when the tab is destroyed #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh hm, this is probably an even bigger deal than #71 since badgeMetrics will never actually error, it will just error asynchronously causing a forever growing set of animations as you accumulate more tabs. Yeah great find @addyosmani! 👍 |
This was important to fix. Thank you, Patrick! I've verified that with all tabs close this avoids memory usage growing and usage seems to settle after tabs get GC'd otherwise. Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kinda fixes #71 (memory usage won't grow when no open tabs, but will still grow while tabs are open until GC'd)