Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Share target #1828

Merged
merged 12 commits into from
Nov 8, 2019
Merged

Share target #1828

merged 12 commits into from
Nov 8, 2019

Conversation

jpmedley
Copy link
Contributor

@jpmedley jpmedley commented Nov 4, 2019

Fixes #1279.

Note: If this is written content for the site please include the issue number from your content proposal.

Changes proposed in this pull request:

  • Update version of the Web Share Target article that originally appeared on WebFu

@jpmedley jpmedley added the DO NOT MERGE Actively working on but experimental label Nov 4, 2019
@googlebot googlebot added the cla: yes Contributor has signed the CLA label Nov 4, 2019
@netlify
Copy link

netlify bot commented Nov 4, 2019

Deploy preview for web-dev-staging ready!

Built with commit 973c7e3

https://deploy-preview-1828--web-dev-staging.netlify.com

@jpmedley jpmedley removed the DO NOT MERGE Actively working on but experimental label Nov 5, 2019
@kaycebasques
Copy link
Contributor

kaycebasques commented Nov 6, 2019

@jpmedley is this ready for review?

@jpmedley
Copy link
Contributor Author

jpmedley commented Nov 6, 2019

@kaycebasques Yes

@robdodson Why are two CI tests shown as pending when the details of those tests show that they exited with status 0?

Floated figures were colliding with asides and bottom page nav.
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Contributor has not signed the CLA and removed cla: yes Contributor has signed the CLA labels Nov 7, 2019
@robdodson robdodson added cla: yes Contributor has signed the CLA and removed cla: no Contributor has not signed the CLA labels Nov 7, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Contributor has not signed the CLA and removed cla: yes Contributor has signed the CLA labels Nov 7, 2019
Copy link
Contributor

@mfriesenhahn mfriesenhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some proposed edits and annotated the ones that go beyond simple mechanical fixes. As always, non-mechanical changes are suggestions; feel free to disregard or change if you don't agree.

src/site/content/en/blog/receive-shared-data/index.md Outdated Show resolved Hide resolved
Comment on lines 53 to 54
After sharing to the demo app, you should see all of the information sent via
the web share target web app.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence doesn't make sense to me: the first phrase says you're sharing to the demo app, while the main clause says you're sharing via the same app. (Or, at least, I'm assuming "demo app" and "web share target web app" are the same thing.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.


### Processing POST shares

If your `method` is `"POST"`, as it would be if it accepted a saved bookmark or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the "it" is in "if it accepted."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@jpmedley
Copy link
Contributor Author

jpmedley commented Nov 7, 2019

PTAL

Copy link
Contributor

@mfriesenhahn mfriesenhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@mfriesenhahn mfriesenhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jpmedley jpmedley mentioned this pull request Nov 8, 2019
8 tasks
@jpmedley
Copy link
Contributor Author

jpmedley commented Nov 8, 2019

#1828 and #1829 (share and share target) are linked to each other. They MUST BE part of the same deployment.

@robdodson robdodson added cla: yes Contributor has signed the CLA and removed cla: no Contributor has not signed the CLA labels Nov 8, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Contributor has not signed the CLA and removed cla: yes Contributor has signed the CLA labels Nov 8, 2019
@kaycebasques kaycebasques merged commit cd8b4a2 into master Nov 8, 2019
@kaycebasques kaycebasques deleted the share-target branch November 8, 2019 21:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: no Contributor has not signed the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

content: migrate "Registering as a Share Target with the Web Share Target API"
5 participants