Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

CDN article #3788

Merged
merged 8 commits into from
Sep 22, 2020
Merged

CDN article #3788

merged 8 commits into from
Sep 22, 2020

Conversation

khempenius
Copy link
Contributor

@khempenius khempenius commented Aug 26, 2020

Fixes #2416

@khempenius khempenius added the DO NOT MERGE Actively working on but experimental label Aug 26, 2020
@khempenius khempenius requested a review from a team as a code owner August 26, 2020 17:01
@googlebot googlebot added the cla: yes Contributor has signed the CLA label Aug 26, 2020
@github-actions
Copy link

Alex Recommends Report

Alex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt.

✨ 🚀 ✨ Nothing to Report ✨ 🚀 ✨

@netlify
Copy link

netlify bot commented Aug 26, 2020

Deploy preview for web-dev-staging ready!

Built with commit a3a0b89

https://deploy-preview-3788--web-dev-staging.netlify.app

@kaycebasques
Copy link
Contributor

Please re-assign to me when it's ready for review.

Copy link

@mnot-fastly mnot-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks really good, left some notes / suggestions for consideration.


* **Dynamic content**

Dynamic content is content that changes frequently. An API response and a store homepage are examples of this content type. However, the fact that this content changes frequently doesn't necessarily preclude it from being cached. During periods of heavy traffic, caching these responses for very short periods of time (e.g. 5 seconds) can significantly reduce the load on the origin server, while having minimal impact on data freshness.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed - controllable/on-demand purging allows more aggressive caching and is a major CDN benefit/feature as well as other invalidation mechanisms.

@kaycebasques
Copy link
Contributor

@khempenius looks like this is waiting on you to review last round of feedback

@khempenius
Copy link
Contributor Author

@dotjs @mnot-fastly thank you for the feedback!

@khempenius khempenius removed the DO NOT MERGE Actively working on but experimental label Sep 14, 2020
@khempenius
Copy link
Contributor Author

@kaycebasques ready for your review

Copy link
Contributor

@kaycebasques kaycebasques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, lots of in-depth ideas that I've never seen before

Tip: Use the batch commit suggestions workflow to incorporate my requested changes faster.

Please break all lines at 100 characters. If you're using VS Code, Rewrap makes it pretty easy to do. The Docs To X Google Docs Add-On also supports this. One reason is because GitHub's UI isn't good at formatting requested changes when lines are long:

image

I noticed a few instances of the passive voice and may want to read again and see if I missed any

We should link to this from web.dev/fast, yeah?

(The requested changes below were auto-generated by the web.dev content review extension)


### HTTP/2 & HTTP/3

HTTP/2 and HTTP/3 both provide performance benefits over HTTP/1. Of the two, HTTP/3 offers greater _potential_ performance benefits. HTTP/3 isn't fully standardized yet, but it will be widely [supported](https://caniuse.com/#feat=http3) once this occurs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason that we are making this strong claim about HTTP/3? It seems risky to say "it will be supported once it gets fully standardized" especially since there are factors outside of our control (other browser vendors)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be OK. H3 is in all major browsers at the moment - albeit behind a flag. My original wording was less strong than this but it was suggested that this would be more accurate.

khempenius and others added 3 commits September 18, 2020 17:41
Co-authored-by: Kayce Basques <kayce@google.com>
Co-authored-by: Kayce Basques <kayce@google.com>
Copy link
Contributor

@kaycebasques kaycebasques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll merge this Tuesday 9/21.

@kaycebasques kaycebasques merged commit 20ef2a8 into master Sep 22, 2020
@kaycebasques kaycebasques deleted the cdn_article branch September 22, 2020 17:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Contributor has signed the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

content: content delivery networks [2020 May 29]
5 participants