Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

add stack pack guidance into each LH audit guide #4093

Closed

Conversation

paulirish
Copy link
Member

@paulirish paulirish commented Oct 19, 2020

Fixes #3674

Changes proposed in this pull request:

  • Add each LH audit's stack pack content into the documentation.

Built via https://github.com/GoogleChrome/lighthouse/compare/updatewebdevwstackpack

@paulirish paulirish requested a review from a team as a code owner October 19, 2020 22:34
@google-cla google-cla bot added the cla: yes Contributor has signed the CLA label Oct 19, 2020
@github-actions
Copy link

Alex Recommends Report

Alex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt.

src/site/content/en/lighthouse-performance/user-timings/index.md

Level Location Word Recommendation
⚠️ 43:6 just just may be insensitive, try not to use it

src/site/content/en/lighthouse-performance/uses-rel-preconnect/index.md

Level Location Word Recommendation
⚠️ 41:47 simple simple may be insensitive, try not to use it

src/site/content/en/lighthouse-performance/uses-responsive-images/index.md

Level Location Word Recommendation
⚠️ 34:27 just just may be insensitive, try not to use it

@netlify
Copy link

netlify bot commented Oct 19, 2020

✔️ Deploy preview for web-dev-staging ready!

🔨 Explore the source changes: 91ac599

🔍 Inspect the deploy logs: https://app.netlify.com/sites/web-dev-staging/deploys/5ff8d970343e4b0007454489

😎 Browse the preview: https://deploy-preview-4093--web-dev-staging.netlify.app

@kaycebasques kaycebasques self-assigned this Oct 20, 2020
@kaycebasques
Copy link
Contributor

Hellooooo just noting that this is on my radar and I'll get to it next week (fingers crossed)

@stale
Copy link

stale bot commented Nov 28, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. To prevent this from happening, leave a comment.

@stale stale bot added the stale label Nov 28, 2020
@paulirish
Copy link
Member Author

not stale

@stale stale bot removed the stale label Nov 30, 2020
@stale
Copy link

stale bot commented Dec 30, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. To prevent this from happening, leave a comment.

@stale stale bot added the stale label Dec 30, 2020
@stale
Copy link

stale bot commented Jan 7, 2021

Closing this issue because it has been marked as stale for more than 7 days.

@stale stale bot closed this Jan 7, 2021
@kaycebasques kaycebasques reopened this Jan 7, 2021
@stale stale bot removed the stale label Jan 7, 2021
@kaycebasques
Copy link
Contributor

I need to make various edits to the writing (breaking lines at 100 characters, etc.) and I don't think I can push to your fork so I will close this and continue in a new branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Contributor has signed the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporating Stack Packs into web.dev
2 participants