Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Add Stack Pack guidance to Lighthouse docs #4444

Merged
merged 5 commits into from Jan 30, 2021
Merged

Conversation

kaycebasques
Copy link
Contributor

@kaycebasques kaycebasques commented Jan 8, 2021

Continuation of #4093

fixes #3674

@google-cla
Copy link

google-cla bot commented Jan 8, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no Contributor has not signed the CLA label Jan 8, 2021
@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Alex Recommends Report

Alex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt.

src/site/content/en/lighthouse-performance/user-timings/index.md

Level Location Word Recommendation
⚠️ 43:6 just just may be insensitive, try not to use it

src/site/content/en/lighthouse-performance/uses-rel-preconnect/index.md

Level Location Word Recommendation
⚠️ 41:47 simple simple may be insensitive, try not to use it

src/site/content/en/lighthouse-performance/uses-responsive-images/index.md

Level Location Word Recommendation
⚠️ 34:27 just just may be insensitive, try not to use it

@netlify
Copy link

netlify bot commented Jan 8, 2021

✔️ Deploy preview for web-dev-staging ready!

🔨 Explore the source changes: 4533ddd

🔍 Inspect the deploy logs: https://app.netlify.com/sites/web-dev-staging/deploys/5ff8e98a27495800083c8c67

😎 Browse the preview: https://deploy-preview-4444--web-dev-staging.netlify.app

@google-cla
Copy link

google-cla bot commented Jan 8, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Jan 8, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@kaycebasques
Copy link
Contributor Author

@paulirish do we need to manually update the Lighthouse UI to link to these sections?

@kaycebasques kaycebasques marked this pull request as ready for review January 8, 2021 23:31
@kaycebasques kaycebasques requested a review from a team as a code owner January 8, 2021 23:31
@kaycebasques kaycebasques self-assigned this Jan 8, 2021
@kaycebasques kaycebasques added cla: yes Contributor has signed the CLA and removed cla: no Contributor has not signed the CLA labels Jan 8, 2021
@paulirish
Copy link
Member

@paulirish do we need to manually update the Lighthouse UI to link to these sections?

nope. the generic LH link will continue pointing to the page itself.
(And this text that's now integrated here is already in the Lightouse report UI)

Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your copyedits look good. 👍

once this lands i'll port your edits back to the stackpack repo so they end up in the lighthouse report.

Base automatically changed from master to main January 28, 2021 20:00
@kaycebasques kaycebasques merged commit 23ac587 into main Jan 30, 2021
@kaycebasques kaycebasques deleted the stackpackincorporated branch January 30, 2021 20:49
@kaycebasques
Copy link
Contributor Author

kaycebasques commented Jan 30, 2021

@paulirish FYI I just merged.

I didn't know this text was in Lighthouse UI. I worry we'll get out-of-sync but we can cross that bridge when we get there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Contributor has signed the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporating Stack Packs into web.dev
2 participants