-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add Stack Pack guidance to Lighthouse docs #4444
Conversation
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Alex Recommends ReportAlex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt. src/site/content/en/lighthouse-performance/user-timings/index.md
src/site/content/en/lighthouse-performance/uses-rel-preconnect/index.md
src/site/content/en/lighthouse-performance/uses-responsive-images/index.md
|
✔️ Deploy preview for web-dev-staging ready! 🔨 Explore the source changes: 4533ddd 🔍 Inspect the deploy logs: https://app.netlify.com/sites/web-dev-staging/deploys/5ff8e98a27495800083c8c67 😎 Browse the preview: https://deploy-preview-4444--web-dev-staging.netlify.app |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
src/site/content/en/lighthouse-performance/efficient-animated-content/index.md
Show resolved
Hide resolved
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@paulirish do we need to manually update the Lighthouse UI to link to these sections? |
nope. the generic LH link will continue pointing to the page itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your copyedits look good. 👍
once this lands i'll port your edits back to the stackpack repo so they end up in the lighthouse report.
@paulirish FYI I just merged. I didn't know this text was in Lighthouse UI. I worry we'll get out-of-sync but we can cross that bridge when we get there. |
Continuation of #4093
fixes #3674