Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

maybe deploy script and split #6103

Merged
merged 2 commits into from
Sep 4, 2021
Merged

maybe deploy script and split #6103

merged 2 commits into from
Sep 4, 2021

Conversation

samthor
Copy link
Contributor

@samthor samthor commented Sep 3, 2021

Splits Cloud Build into two parts. One which checks the current version and might set off another task, and one that actually does the deploy.

Alternatives considered:

  • one single task with conditional steps (not really supported, needs lots of bash): fine, but unreadable
  • detecting cancels (hard, they're logged as failures)

Once this is ready to go, I will flip the hourly trigger over on Cloud Console, as it currently points to "deploy". We'll need to point it to this "maybe-deploy" trigger.

If either tasks fails, we'll be notified, because we're still watching for errors. That process doesn't need to change.

@netlify
Copy link

netlify bot commented Sep 3, 2021

✔️ Deploy Preview for web-dev-staging ready!

🔨 Explore the source changes: 2f134b7

🔍 Inspect the deploy log: https://app.netlify.com/sites/web-dev-staging/deploys/6132d28fa0bf5f0007738d7a

😎 Browse the preview: https://deploy-preview-6103--web-dev-staging.netlify.app

@google-cla google-cla bot added the cla: yes Contributor has signed the CLA label Sep 3, 2021
@pullapprove pullapprove bot requested a review from devnook September 3, 2021 04:41
Copy link
Contributor

@MichaelSolati MichaelSolati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Though 1) the cron on GCP will need to be updated to trigger the maybe deploy. 2) I don't like the "maybe deploy" name... Maybe it could be "deploy check" or "release check?"

@samthor
Copy link
Contributor Author

samthor commented Sep 4, 2021

Renamed back to "version-check" as per discussion in Chat.

@samthor samthor merged commit 9033e1c into main Sep 4, 2021
@samthor samthor deleted the maybe-build branch September 4, 2021 01:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Contributor has signed the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants