Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Building Designcember post #7092

Merged
merged 7 commits into from
Dec 28, 2021
Merged

Building Designcember post #7092

merged 7 commits into from
Dec 28, 2021

Conversation

rachelandrew
Copy link
Collaborator

@rachelandrew rachelandrew commented Dec 22, 2021

Fixes: #6783

Post for Dec 28.

@chrome-devrel-review-bot
Copy link
Collaborator

chrome-devrel-review-bot commented Dec 22, 2021

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

src/site/content/en/blog/how-we-built-designcember/index.md

@netlify
Copy link

netlify bot commented Dec 22, 2021

✔️ Deploy Preview for web-dev-staging ready!

🔨 Explore the source changes: b445f20

🔍 Inspect the deploy log: https://app.netlify.com/sites/web-dev-staging/deploys/61c5060bed7eff0008e4c921

😎 Browse the preview: https://deploy-preview-7092--web-dev-staging.netlify.app

rachelandrew and others added 3 commits December 22, 2021 15:37
* update videos and images, some text

* added missing alt text

* image replacements and more adjustments
@rachelandrew rachelandrew added the DO NOT MERGE Actively working on but experimental label Dec 23, 2021
Copy link
Contributor

@alexandrascript alexandrascript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits for grammar / style guide.

Plus, 👏🏻 👏🏻 👏🏻 for the screen reader coverage.

Co-authored-by: Alexandra White <alexandrawhite@google.com>
@rachelandrew
Copy link
Collaborator Author

This is now failing the linter, I'll figure it out tomorrow unless @heyawhite can spot it.

@alexandrascript
Copy link
Contributor

alexandrascript commented Dec 23, 2021 via email

@alexandrascript
Copy link
Contributor

@rachelandrew it was an HTML character problem -- it's been resolved. Good to go!

@rachelandrew rachelandrew added $-presubmit Add label to run presubmit tests. and removed DO NOT MERGE Actively working on but experimental labels Dec 28, 2021
@github-actions github-actions bot removed the $-presubmit Add label to run presubmit tests. label Dec 28, 2021
@rachelandrew rachelandrew merged commit 9a80c90 into main Dec 28, 2021
@rachelandrew rachelandrew deleted the designcember-how-we-built branch December 28, 2021 04:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CSS] How we built designcember.com [12/28/2021]
4 participants