This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
Add initial Layout Instability API draft #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdodson
reviewed
Jun 11, 2019
|
|
||
| Here are a few examples of how the layout shift score is calculated: | ||
|
|
||
|  |
There was a problem hiding this comment.
For all of the image examples, would you mind enhancing the alt text a bit? If you were describing the image to someone over the phone how would you phrase it?
robdodson
reviewed
Jun 11, 2019
| }); | ||
| ``` | ||
|
|
||
| <div class="w-aside w-aside--note"> |
There was a problem hiding this comment.
We have shortcodes you can use for this. Sorry if it's not well documented.
{% Aside 'note' %}
[you can put markdown in here]
{% endAside %}
There was a problem hiding this comment.
I wanted to customize what was bolded, and it didn't seem like I could do that with the short codes. Let me know if I'm wrong.
robdodson
approved these changes
Jun 11, 2019
philipwalton
force-pushed
the
layout-instability-api
branch
from
770b635
to
ce7bc34
Compare
philipwalton
force-pushed
the
layout-instability-api
branch
from
ce7bc34
to
a83e103
Compare
robdodson
approved these changes
Jun 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #993.
This PR is an initial draft that I'd like to get reviewed (as this is my first PR to web.dev).
I'm also waiting on some additional feedback from a few other folks, so please don't merge/publish until I give the go-ahead.