Properly deal with webpack's publicPath + importWorkboxFrom: 'local' #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addyosmani
reviewed
Jan 13, 2018
| const modulePathPrefix = path.dirname(libraryFiles[0]); | ||
|
|
||
| const basenames = libraryFiles.map((file) => path.basename(file)); | ||
| expect(basenames).to.eql([ |
There was a problem hiding this comment.
My only passing comment is that it appears lines 197 and 311 execute expect(basenames).to.eql() against the same list of dev, prod and map files - should this list of basenames be turned into a variable if they're the same between both tests? If I missed something and they're not exactly 1:1, feel free to ignore.
There was a problem hiding this comment.
Good point. Changing!
PR-Bot Size PluginChanged File SizesNo file sizes have changed. New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin☠️ WARNING ☠️We are using 153% of our max size budget. Total Size: 22.38KB Gzipped: 8.96KB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @addyosmani @gauntface
Fixes #1172
This was due to a missing
()around an||operator.