-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade test suite to use selenium-webdriver v4 #2151
Conversation
cache: | ||
directories: | ||
- "$HOME/.npm" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the story here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per https://docs.travis-ci.com/user/caching/#npm-cache, it should happen automatically now.
PR-Bot Size PluginChanged File Sizes
New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin3.5KB gzip'ed (23% of limit) |
(Here's the before-and-after of |
Based on eyeballing the diff locally, it looks like the bulk of the changes in the
|
This PR updates our dependency on
selenium-assistant
to v6.0.0, which supports a version of the underlyingselenium-webdriver
project that will work with Safari.It also changes our Travis CI config to use an OS X container instead of Linux, which will result in our Safari tests being run as part of our CI. (This unfortunately takes a long-ish time to complete.)
To work around some issues related to
chromedriver
(andgeckodriver
) versioning, it removes them frompackage.json
and instead installs them fresh before everygulp test-integration
.(There's a somewhat mysterious increase in size in the
packages/workbox-window/build/workbox-window.dev.umd.js
bundle reported by thePR-Bot Size Plugin
, and I'm not sure what's up with that? It might be because the various Babel-related dependencies that were locked to earlier versions in our oldpackage-lock.json
have been updated?)