Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compileSrc option to InjectManifet webpack plugin #2412

Merged
merged 3 commits into from
Mar 19, 2020

Conversation

jeffposnick
Copy link
Contributor

R: @philipwalton
CC: @bailnl

Fixes #2383

When compileSrc is set to false, the swSrc file won't be run through the webpack compilation process. That allows for the use case described in #2383, where the manifest ends up injected into an arbitrary file that might not be something that should be processed by webpack.

The default behavior has not changed.

@jeffposnick jeffposnick merged commit 1a77f7f into master Mar 19, 2020
@jeffposnick jeffposnick deleted the webpack-compileSrc branch March 19, 2020 13:56
@bailnl
Copy link

bailnl commented Mar 23, 2020

thanks ~ @jeffposnick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use workbox-webpack-plugin to generate a standalone precache manifest
3 participants