Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] (workbox-cli) Prompt for 'ignoreURLParametersMatching' in workbox wizard #2763

Merged
merged 5 commits into from
Mar 1, 2021
Merged

[Feature] (workbox-cli) Prompt for 'ignoreURLParametersMatching' in workbox wizard #2763

merged 5 commits into from
Mar 1, 2021

Commits on Feb 25, 2021

  1. feat: 🎸 Add a question to workbox-cli 

    Extend workbox-cli with a question regarding the
'ignoreURLParametersMatching' workbox config parameter.

✅ Closes: GoogleChrome#2758
    Ognjen Jevremovic committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    43c755e View commit details
    Browse the repository at this point in the history

  2. refactor: 💡 workbox-cli ignore url parameters improvemenets 

    Provide assertions to workbox-cli package regarding question for
'ignoreURLParametersMatching' workbox config parameter with meaningful
error messages.
    Ognjen Jevremovic committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    bcee650 View commit details
    Browse the repository at this point in the history

  3. fix: 🐛 workbox-cli ignore url parameters configuration 

    Provided instances of RegExp (for ignoring the set of search parameters)
should be converted to string values (using the native
RegExp.prototype.toString method), as JSON.stringify is not able to
convert RegExp class instances into corresponding regular expressions
before writing the configuration to workbox-config.js file.
    Ognjen Jevremovic committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    4a506b1 View commit details
    Browse the repository at this point in the history

  4. refactor: 💡 workbox-cli ignore url parameters defaults 

    Refactor defaults for 'ignoreURLParametersMatching' config parameter
into constants.
    Ognjen Jevremovic committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    10342c8 View commit details
    Browse the repository at this point in the history

  5. test: 💍 workbox-cli questions tests 

    Provide tests for the query parameters in start url question (tests
lib/questions/ask-start_url-query-params). Extend the
lib/questions/ask-questions.js tests with newly added question.

✅ Closes: GoogleChrome#2758
    Ognjen Jevremovic committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    4db06a6 View commit details
    Browse the repository at this point in the history