Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skips BOM on Web Manifests #685

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Skips BOM on Web Manifests #685

merged 1 commit into from
Apr 29, 2022

Conversation

andreban
Copy link
Member

  • Downloads manifest as String and trims before parsing the JSON.

- Downloads manifest as String and trims before parsing the JSON.
@andreban andreban requested a review from PEConn April 28, 2022 17:47
@andreban andreban added the enhancement New feature or request label Apr 28, 2022
Copy link
Collaborator

@PEConn PEConn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth while making a util method, something like ForgivinglyParseJson or ParseJsonTryingOurBestToMakeItWork?

Approved though.

@andreban
Copy link
Member Author

Yeah, if I get more places where I need it I'll wrap in a function.

@andreban andreban merged commit a93e945 into main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants