-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No log.entryAdded
after navigation
#620
Comments
I wonder if we can replace
with
? |
I cannot reproduce it in BiDi. The following test passes:
|
@sadym-chromium let me know if you manage to create a repro. |
thiagowfx
added a commit
that referenced
this issue
Apr 17, 2023
I can confirm that the suggestion in comment works, as long as it's not awaited. |
thiagowfx
added a commit
that referenced
this issue
Apr 19, 2023
thiagowfx
added a commit
that referenced
this issue
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If we navigate to a page that log things on load (
ReadinessState == 'complete'
).An repo Puppeteer Script be seen at #10032.
After an investigation I was able to deduce that the
RealmStorage
is being cleared by the CDPPage.frameNavigated
event.And the
Runtime.executionContextCreated
event creates a new Realm.The first event handler is Async while the second is Sync. I think we are creating a
new Realm
then the first is awaited and we delete all the old Realms for the BrowsingContext included the newly created on.The line that is doing this.
If I reorder the
this.#realmStorage.deleteRealms
beforeawait this.#deleteChildren();
things work as expected.Please check if there is a specific reason for the current order of operation.
The text was updated successfully, but these errors were encountered: