Fix BrowsingContext re-initialisation race condition #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagowfx
reviewed
Apr 20, 2023
thiagowfx
approved these changes
Apr 20, 2023
thiagowfx
approved these changes
Apr 20, 2023
thiagowfx
pushed a commit
that referenced
this pull request
Apr 21, 2023
* Rely on `Runtime.executionContextCreated` event * Remove unnecessary async event handlers --------- Co-authored-by: Maksim Sadym <sadym@google.com>
thiagowfx
pushed a commit
that referenced
this pull request
Apr 21, 2023
* Rely on `Runtime.executionContextCreated` event * Remove unnecessary async event handlers --------- Co-authored-by: Maksim Sadym <sadym@google.com>
thiagowfx
pushed a commit
that referenced
this pull request
Apr 21, 2023
* Rely on `Runtime.executionContextCreated` event * Remove unnecessary async event handlers --------- Co-authored-by: Maksim Sadym <sadym@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause of the #620 was exactly as described @Lightning00Blade. While
Page.frameNavigatedevent was fired beforeRuntime.executionContextCreated, as it's async, it's last part with cleaning realms was run afterRuntime.executionContextCreatedhandled.This fix includes 2 parts:
Runtime.executionContextsClearedevent rather thenPage.frameNavigatedto clean Realms.Tested manually with Puppeteer and repro script from the puppeteer/puppeteer#10032. Couldn't reproduce with Mapper Tab and therefor couldn't add e2e test.