Fix BrowsingContext re-initialisation race condition #629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause of the #620 was exactly as described @Lightning00Blade. While
Page.frameNavigated
event was fired beforeRuntime.executionContextCreated
, as it's async, it's last part with cleaning realms was run afterRuntime.executionContextCreated
handled.This fix includes 2 parts:
Runtime.executionContextsCleared
event rather thenPage.frameNavigated
to clean Realms.Tested manually with Puppeteer and repro script from the puppeteer/puppeteer#10032. Couldn't reproduce with Mapper Tab and therefor couldn't add e2e test.