New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency clean-webpack-plugin to v3 #420
Conversation
PR has been edited👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description. |
@foolip I'm taking a look now |
@foolip this problem should now be fixed. Can you tick the rebase/retry checkbox above and then we can hopefully confirm that no "PR has been edited" comment remains? Then we can close renovatebot/renovate#3818 once confirmed |
@rarkins I've checked the box, but I see that CI has failed so this won't be merged anyway. |
c255aa0
to
fbdfc53
Compare
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
=======================================
Coverage 53.52% 53.52%
=======================================
Files 54 54
Lines 1659 1659
=======================================
Hits 888 888
Misses 771 771
Continue to review full report at Codecov.
|
@rarkins this was a major version upgrade and so wasn't going to be automerged anyway, but now that I fixed the CI failure by pushing another commit the CLA bot is unhappy again. I'm pretty sure this is just because of the extra commit on the branch and will merge anyway, but I'll check on the next upgrade PR which is eligible for automerge if all is well. |
This PR contains the following updates:
2.0.2
->3.0.0
Release Notes
johnagan/clean-webpack-plugin
v3.0.0
Compare Source
cleanOnceBeforeBuildPatterns
useemit
hook instead ofcompile
CleanWebpackPlugin
Renovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "
rebase!
".🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot. View repository job log here.