Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency clean-webpack-plugin to v3 #420

Merged
merged 2 commits into from Jun 3, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 30, 2019

This PR contains the following updates:

Package Type Update Change
clean-webpack-plugin devDependencies major 2.0.2 -> 3.0.0

Release Notes

johnagan/clean-webpack-plugin

v3.0.0

Compare Source

  • Removed Node 6 support
  • Removed webpack 2 support
  • cleanOnceBeforeBuildPatterns use emit hook instead of compile
  • Do not clean files if webpack errors are present during initial build
  • Replaced default export with named export CleanWebpackPlugin
// es modules
import { CleanWebpackPlugin } from 'clean-webpack-plugin';

// common js
const { CleanWebpackPlugin } = require('clean-webpack-plugin');

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@renovate
Copy link
Contributor Author

renovate bot commented May 30, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@rarkins
Copy link

rarkins commented May 30, 2019

@foolip I'm taking a look now

@rarkins
Copy link

rarkins commented May 30, 2019

@foolip this problem should now be fixed. Can you tick the rebase/retry checkbox above and then we can hopefully confirm that no "PR has been edited" comment remains? Then we can close renovatebot/renovate#3818 once confirmed

@foolip
Copy link
Member

foolip commented May 31, 2019

@rarkins I've checked the box, but I see that CI has failed so this won't be merged anyway.

@renovate renovate bot force-pushed the renovate/clean-webpack-plugin-3.x branch from c255aa0 to fbdfc53 Compare May 31, 2019 19:05
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@codecov-io
Copy link

codecov-io commented Jun 3, 2019

Codecov Report

Merging #420 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #420   +/-   ##
=======================================
  Coverage   53.52%   53.52%           
=======================================
  Files          54       54           
  Lines        1659     1659           
=======================================
  Hits          888      888           
  Misses        771      771
Flag Coverage Δ
#chrome 55% <ø> (ø) ⬆️
#firefox 55% <ø> (ø) ⬆️
#node10 73.53% <ø> (ø) ⬆️
#node12 73.53% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29d8505...3a7e543. Read the comment docs.

@foolip
Copy link
Member

foolip commented Jun 3, 2019

@rarkins this was a major version upgrade and so wasn't going to be automerged anyway, but now that I fixed the CI failure by pushing another commit the CLA bot is unhappy again. I'm pretty sure this is just because of the extra commit on the branch and will merge anyway, but I'll check on the next upgrade PR which is eligible for automerge if all is well.

@foolip foolip merged commit c7efcba into master Jun 3, 2019
@foolip foolip deleted the renovate/clean-webpack-plugin-3.x branch June 3, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants