-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Adding in missing getter for document.head
#87
Conversation
|
||
document.body.appendChild(document.createTextNode('this counts as SSR')); | ||
|
||
import('./chunk.js').then(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's a slightly less awkward way to create another chunk, certainly let me know. This was just to generate another stylesheet
<style>html { | ||
padding: 0px; | ||
} | ||
|
||
html { | ||
padding: 0px; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately this is correct at the moment, and Critters no longer dedupes, see #88
@developit Sorry to ping, but any chance you could take a look at this? This is the only remaining blocker for upgrading to HtmlWebpack v4 in preact-cli |
@rschristian published as critters@0.0.15! |
Thanks! |
Closes #69
Simply missing a getter for
head
.Full stack trace of the error that this fixes. The one in the linked issue is fairly outdated and the error position is no longer correct:
Adds a couple tests to ensure
additionalStylesheets
works.