Skip to content
This repository has been archived by the owner on Sep 10, 2022. It is now read-only.

Http2 push on sample app not working ? #20

Open
fabito opened this issue Jun 22, 2016 · 17 comments
Open

Http2 push on sample app not working ? #20

fabito opened this issue Jun 22, 2016 · 17 comments

Comments

@fabito
Copy link

fabito commented Jun 22, 2016

I'm trying the sample app https://http2-push.appspot.com/ using Chromne Version 51.0.2704.103 (64-bit) on Ubuntu.

Although the Link header is present seems that nothing is being pushed.
I only see "quic/1+spdy/3" instead "h2".

http2-push-fail

@ebidel
Copy link
Contributor

ebidel commented Jun 22, 2016

This is a known issue with chromen atm. It's defaulting to the quic
protocol which doesn't yet support push. That'll be fixed soon.

On Wed, Jun 22, 2016, 5:57 AM Fábio Franco Uechi notifications@github.com
wrote:

I'm trying the sample app https://http2-push.appspot.com/ using Chromne
Version 51.0.2704.103 (64-bit) on Ubuntu.

Although the Link header is present seems that nothing is being pushed.
I only see "quic/1+spdy/3" instead "h2".

[image: http2-push-fail]
https://cloud.githubusercontent.com/assets/308613/16254237/335c689c-3814-11e6-91a7-2c0429cc84a9.png


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#20, or mute the
thread
https://github.com/notifications/unsubscribe/AAOigNDGMXN8ilKr0ug8iBlHNuUs8eesks5qOLKfgaJpZM4I7Yob
.

@fabito
Copy link
Author

fabito commented Jun 22, 2016

Weird, on another webapp also running on GAE assets are being pushed normally.

sc-http2-push

@ciampo
Copy link

ciampo commented Sep 5, 2016

@ebidel Any updates on this issue? Our team is trying to implement the PRPL pattern with a GAE server, and this is the only module that we know that enables HTTP2 Push

@ebidel
Copy link
Contributor

ebidel commented Sep 5, 2016

I believe the goal was to get quic + h2 push working this quarter, but now update (yet) on the GAE side of things.

@ebidel
Copy link
Contributor

ebidel commented Sep 5, 2016

@ciampo you don't need this module to do h2 push on GAE. That's a feature that the core service supports. Just construct the link preload header. All this module does is enable an easier way to construct that header and annotate server endpoints.

@WillDonohoe
Copy link

Right - so if I understand this correctly, this module makes it easier to implement server push on GAE, but we're waiting for the Google Cloud team to implement server push fully?

@ebidel
Copy link
Contributor

ebidel commented Sep 26, 2016

Google Cloud team to implement server push fully

It should be everywhere on Google's infrastructure. What service are you using that you're not seeing pushed results?

@WillDonohoe
Copy link

We're using standard Google App Engine, along with setting the link http header to set the pushed resources.

What I'm expecting is something similar to the Polymer Shop application (although this is running on Apache I believe):

screen shot 2016-09-26 at 4 22 31 pm

Where as this is what we see on the demo page: (We're seeing the same results on our application).

screen shot 2016-09-26 at 4 17 43 pm

Is this caused by the initial answer to this thread where push is not supported by QUIC in chrome at the moment? If so, is there any ETA on when this might be fixed?

@ebidel
Copy link
Contributor

ebidel commented Sep 26, 2016

Ah yes, that's #20 (comment). It's supposed to be fixed this quarter :\ I believe https://bugs.chromium.org/p/chromium/issues/detail?id=622043 is the issue to follow. FWIW, I'm seeing "h2" request on that demo page, not quic.

@WillDonohoe
Copy link

Ah I see, thanks for your response @ebidel. It's interesting that you're getting h2 on that demo, whereas we're getting QUIC, I'm seeing this in canary too.

Hopefully a fix will come soon!

@ebidel
Copy link
Contributor

ebidel commented Sep 26, 2016

It's possible Chrome is still running experiments for different users. You can change the behavior in about:flags to enable/disable it. Mine is set to "default" in stable.

screen shot 2016-09-26 at 12 12 53 pm

@WillDonohoe
Copy link

Yeah my settings in about:flags are also set to default too.

In the meantime, we've found it quite difficult to see if resources are being pushed to the front end outside Chrome, other than looking at the headers. Other browser dev tools don't seem to include it, or if they do, they keep it well hidden!

We came across a node module that Surma wrote, which reports the resources that are pushed. It's worked out nicely, if anybody else needs to check if they have their server pushing files correctly 👍

screen shot 2016-09-27 at 5 43 33 pm

@ebidel
Copy link
Contributor

ebidel commented Sep 27, 2016

Take a look at chrome://net-internals/#http2 to very what push promises are being recv'd and accepted.

@vorcigernix
Copy link

I still have this issue on my chromebook. Had to disable QUIC manually.

@beaufortfrancois
Copy link
Contributor

@ebidel I still have this issue as well.
https://bugs.chromium.org/p/chromium/issues/detail?id=622043 is fixed but Push / foo still does not show up in DevTools.

Do you know who we can ping?

cc @Deleplace

@ebidel
Copy link
Contributor

ebidel commented Sep 19, 2018

What do you see on https://shop.polymer-project.org/? I see h2 requests.

@paulirish might know from the Devtools side.

@beaufortfrancois
Copy link
Contributor

beaufortfrancois commented Sep 20, 2018

I also see h2 requests for https://shop.polymer-project.org/.
image

However for https://http2-push.appspot.com/ I see http/2+quic/44 requests without `Push / ...'
image

On firebase hosting at https://fbpush2019-09-19.firebaseapp.com/ I see h2 requests but sometimes with Push / and sometimes not ;(
image
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants