-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not remove pre-existent #.*:
section of URI.
#92
Comments
#[A-Za-z0-9]+:
section of URI.#.*:
section of URI.
This has been discussed in WICG/scroll-to-text-fragment#75. The spec also has a section about this question. There are two cases: the first case is the one where the page actually has an element with the hash ID, like |
@tomayac, WICG/scroll-to-text-fragment#75 (comment) discusses the behaviour of the search functionality when the fragment is included with the directive. I don't care about that; I just want this extension to not remove that portion because it causes issues when the fragment isn't used for searching the page. Fragments are frequently used for other purposes, so they're as important a part of any URI as any other. WICG/scroll-to-text-fragment#75 (comment) states
so I'm extra confused by why keeping the fragment included isn't desirable. |
Just submitted v2.4.0 to the store that preserves potentially existing hashes. |
If I use the extension on https://www.myheritage.com/FP/memberEditProfile.php?s=781598791&memberID=1085838471&sourceList=#notificationPanelAnchor:~:text=I%20am%20researching%3A-,my%20email%20,-Email%3A at https://www.myheritage.com/FP/memberEditProfile.php?s=781598791&memberID=1085838471&sourceList=#notificationPanelAnchor,
notificationPanelAnchor
is removed, resulting in https://www.myheritage.com/FP/memberEditProfile.php?s=781598791&memberID=1085838471&sourceList=#:~:text=I%20am%20researching%3A-,my%20email%20,-Email%3A.This is erroneous, because that part of the URI has meaning, especially in circumstances where it isn't simply used to communicate where scroll the page to. However, in the instances that it is, such as at https://en.wikipedia.org/wiki/Allied_invasion_of_Italy#Salerno_landings, it is a useful fallback for browsers where fragment support is unavailable.
The text was updated successfully, but these errors were encountered: