feat(rpc): migrate to carlo.loadParams(). (#187)

GoogleChromeLabs · Nov 23, 2018 · 3722a3e · 3722a3e
1 parent 238e61b
commit 3722a3e
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 12 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -71,7 +71,7 @@ module.exports = {
         "no-unsafe-negation": 2,
         "radix": 2,
         "valid-typeof": 2,
-        "no-unused-vars": [2, { "args": "none", "vars": "local", "varsIgnorePattern": "(_|carloRpcWorldParams|load)" }],
+        "no-unused-vars": [2, { "args": "none", "vars": "local", "varsIgnorePattern": "(_|load)" }],
         "no-implicit-globals": [2],
 
         // es2015 features

diff --git a/front_end/ndb/InspectorFrontendHostOverrides.js b/front_end/ndb/InspectorFrontendHostOverrides.js
@@ -11,7 +11,7 @@
     const threads = runtime._extensions.find(e => e._descriptor.className === 'Sources.ThreadsSidebarPane');
     threads._descriptor.className = 'UI.Widget';
     threads._descriptor.title = 'Node processes';
-    Ndb.backend = await carloRpcWorldParams;
+    [Ndb.backend] = await carlo.loadParams();
     const info = await getProcessInfo();
     hostBackend = await Ndb.backend.createService('inspector_frontend_host.js', info.configDir);
     callback(await hostBackend.getPreferences());

diff --git a/front_end/ndb_app.js b/front_end/ndb_app.js
@@ -2,10 +2,4 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// TODO: expose Carlo's RPC world params to userland.
-const carloRpcWorldParams = new Promise(resolve => self.load = backend => {
-  delete self.load;
-  resolve(backend);
-});
-
 Runtime.startApplication('ndb_app');
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -21,7 +21,7 @@
   "author": "The Chromium Authors",
   "license": "Apache-2.0",
   "dependencies": {
-    "carlo": "^0.9.29",
+    "carlo": "^0.9.31",
     "chokidar": "^2.0.4",
     "fs-copy-file-sync": "^1.1.1",
     "isbinaryfile": "^3.0.3",