Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/common use cases #114

Merged
merged 29 commits into from
Apr 6, 2020
Merged

Feature/common use cases #114

merged 29 commits into from
Apr 6, 2020

Conversation

JuanMaRuiz
Copy link
Contributor

Hi @exterkamp as discussed in #80 here is the PR with the proposal of the new README section.

What do you think?

Best regards.

JuanMaRuiz and others added 28 commits October 26, 2019 17:11
- Removed call to api.
- Added test to options handler instead
- Merge branch 'feature-optimizing-test' of https://github.com/JuanMaRuiz/psi into feature-optimizing-test
- Removed api-response-test
Co-Authored-By: Shane Exterkamp <shaneexterkamp5@gmail.com>
Co-Authored-By: Shane Exterkamp <shaneexterkamp5@gmail.com>
Copy link
Collaborator

@exterkamp exterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, exactly what I wanted! 👏 Just some wording changes and it's g2g

README.md Outdated Show resolved Hide resolved
Co-Authored-By: Shane Exterkamp <shaneexterkamp5@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants