Require Node.js 6 and use pagespeed v4 #95
Conversation
|
PageSpeed Insights API v5 has now been released, I guess we might as well update to that version instead of targeting v4. https://developers.google.com/speed/docs/insights/release_notes |
|
Thanks @mansn! I think know. I'll try to update to the new version 👍 |
|
Hi! I have tried to use the last version of pagespeed (v5) but seems it's not included yet in the googleapis package used in this tool. What do you think @mansn ? Do you know how to use the last version in the way is used in this tool?? Where can I find it? Thanks in advance. |
|
@JuanMaRuiz Ah, sorry. I totally missed to do my homework and check the dependencies before making previous comment. My bad! |
|
Hey folks. Really sorry for the radio silence here. As we've shipped PSI's V5 API, would anyone like to explore updating the package to use that instead? It'd be a nice release as we now expose Lighthouse results there too. I'm also more than happy to take on more co-maintainers if folks are actively using this package. |
|
Hi! You have nothing to be sorry for @addyosmani. According with npm the number of weekly downloads of this package is ~8000 so it seems folks are still using it. I can try to update to PSI V5. Best regards. |
|
@JuanMaRuiz any help at all with updating to PSI V5 would be greatly appreciated. Thank you :) Fyi, added you to the repo too. |
|
Many thanks @addyosmani for adding me to the repo. I really appreciate it! |
JuanMaRuiz
requested review from
sindresorhus
and removed request for
sindresorhus
sindresorhus
changed the title
|
Merging. Let's continue the v5 discussion in #97. |
Seems that google redirects to a failure page when test are launched in travis. Due that the title doesn't match with the expected in the test so the test fails. Because of that I have changed the page setted in the test and now all test pass again.
Best regards.
Closes #90