Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial documentation for Multi-Screen Window Placement #18

Merged
merged 13 commits into from
Feb 5, 2021
Merged

Add initial documentation for Multi-Screen Window Placement #18

merged 13 commits into from
Feb 5, 2021

Conversation

inexorabletash
Copy link
Collaborator

@inexorabletash inexorabletash commented Jan 8, 2021 •
edited
Loading

jpmedley
jpmedley suggested changes Jan 8, 2021
View reviewed changes
content/en-US/api/getScreens.md Outdated Show resolved Hide resolved
content/en-US/api/getScreens.md Outdated Show resolved Hide resolved
content/en-US/api/getScreens.md Outdated Show resolved Hide resolved
content/en-US/api/getScreens.md Outdated Show resolved Hide resolved
content/en-US/api/getScreens.md Outdated Show resolved Hide resolved
content/en-US/api/Screens.md Outdated Show resolved Hide resolved
content/en-US/api/Screens.md Show resolved Hide resolved
content/en-US/api/isExtended.md Show resolved Hide resolved
content/en-US/api/currentScreen.md Outdated Show resolved Hide resolved
content/en-US/api/screens.md Outdated Show resolved Hide resolved
@inexorabletash @jpmedley
Update content/en-US/api/ScreenAdvanced.md
49997e0 
Co-authored-by: Joe Medley <jmedley@google.com>
@inexorabletash
Copy link
Collaborator Author

Oops, thanks for the ping.

@inexorabletash
Copy link
Collaborator Author

Anything else needed from me?

@inexorabletash
Copy link
Collaborator Author

And... do we want @michaelwasserman to review first?

michaelwasserman
michaelwasserman approved these changes Jan 25, 2021
View reviewed changes
Copy link

@michaelwasserman michaelwasserman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this; where will this documentation appear?
My only suggestion is potentially adding the recently proposed ScreenAdvanced.label member;

content/en-US/api/ScreenAdvanced.md Show resolved Hide resolved
michaelwasserman
michaelwasserman suggested changes Jan 25, 2021
View reviewed changes
Copy link

@michaelwasserman michaelwasserman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I caught one bit that seems inaccurate.

content/en-US/api/Screens.md Show resolved Hide resolved
@inexorabletash
Copy link
Collaborator Author

where will this documentation appear?

This will populate MDN

michaelwasserman
michaelwasserman approved these changes Jan 26, 2021
View reviewed changes
Copy link

@michaelwasserman michaelwasserman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg, thanks!

@jpmedley jpmedley merged commit 52d14a9 into puppy Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmedley jpmedley jpmedley approved these changes

@michaelwasserman michaelwasserman michaelwasserman approved these changes

Assignees
No one assigned
Labels
Draft Added
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inexorabletash @jpmedley @michaelwasserman