-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option to load/save build diff stats #21
Conversation
Seems like we have out-dated snapshots. |
@kuldeepkeshwar yup, good to update! |
By default, when
|
This also resolves #22 |
@developit can you please review it |
* mjs to js * updated package.json * fixed typo (,) * added publish-size * publish size for master branch * fixed typo * fixed payload for size api * size-store api configurable via env variable * avoid publishing in test environment * added todo * pushed filename to store * checked file before writing/reading * corrected file write condition * updated test * moved fs-extra to dependencies * added filename to diff payload * add publish flag * add writeFile option * js to mjs
@developit summarizing the final changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Only thing I think we should consider is defaulting |
Good point, it should definitely be opt-in instead of opt-out 👍 |
@developit, addressed the review comments & updated code accordingly |
@developit should we also make |
@kuldeepkeshwar Not sure on that one actually. One option here that might help simplify would be if we removed
|
Co-Authored-By: Jason Miller <developit@users.noreply.github.com>
@developit, can we merge this? let me know if you have other thoughts in mind. |
With this developer can load the stats & save them back.
stats format:(As mentioned here)
Example:
This should solve #15 & #6