Preload test #262
Merged
Preload test #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something's blocking first render and interaction. Looks like it's either CSS or analytics. |
|
Oh shit wait it's analytics. It's a blocking script in the head. |
|
The prerenderer is fucking up here. We add analytics dynamically, and it's keeping that dom for the prerender. I'll fix. |
|
(I mean, the prerenderer isn't fucking up, it's doing exactly what we asked it to do, we just didn't think it through) |
|
Ta-da! Back under 5s to interactive on 2g. https://www.webpagetest.org/video/compare.php?tests=181110_EF_b929bd0f1820815166f595a6cad27c86-r%3A2-c%3A0&thumbSize=200&ival=100&end=visual |
|
Forgive me for merging this without review. |
alisaitbilgi
pushed a commit
to alisaitbilgi/squoosh
that referenced
this pull request
Feb 19, 2019
* Preload test * Don't prerender analytics * Version bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing what's faster