Promisify emscripten modules & fix webp examples #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh I didn't see this PR, sorry @manzt! I did something very similar in I think we can merge this PR first, and rebase mine on top. @surma WDYT? |
|
Go for it. |
RReverser
approved these changes
Sep 29, 2020
|
Heh, I also did this in the rollup-build branch 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems a promise-based API was added to modularized Emscripten builds in response to emscripten-core/emscripten#5820:
PR: emscripten-core/emscripten#10697
Since consolidating C++ builds (#781), the
emscripten/emsdkDocker image produces module factory functions that return a promise for the emscripten module. This PR:webpexamples:codecs/webp/enc/example.html&codecs/webp/dec/example.htmlby using the new promise-based API.initEmscriptenModuleto just call module factory.PS: Thanks for all the work here. I've modeled the C++ builds for one of my projects on squoosh's codecs, which is how I ran into this. Much appreciated!