This repository has been archived by the owner on Jan 23, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @addyosmani @gauntface
This drops support for node 0.12.x, and imposes a minimum version of node 4.0.0 via the
engines
field inpackage.json
.node 0.12.x reached its official end-of-life at the end of 2016.
Since we can now assume node 4+, there are a few dependencies that we can now update that assume node 4+ functionality.
This includes updates to our default
eslint
rules. I've explicitly disabled some of the new default rules for this project, since, e.g., updating all of ourvar
toconst
/let
is outside of the scope of work we want to do withsw-precache
.This change will be rolled into an upcoming major version bump (to 5.0.0) release of
sw-precache
.Fixes #203