New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown fixes #321
Markdown fixes #321
Conversation
🚀 Deploy preview for 15f7a1b: firebase-preview-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed. nice work.
if (infostring === 'sh') { | ||
infostring = ''; | ||
infostring = 'shell-session'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
omg shell-session
? Really?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah 😞
@@ -23,7 +23,7 @@ export function createRenderer() { | |||
if (infostring === 'sh') { | |||
infostring = ''; | |||
} | |||
if (!infostring || infostring.length <= 0) { | |||
if (!infostring) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I never think of ""
as a false-y value 🙄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be fair, it took me a while to notice it
<!DOCTYPE html> | ||
… | ||
```html | ||
<!DOCTYPE html> … |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakearchibald Is this an intentional change? Seems weird that they're on the same line now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was Prettier enforced, but it didn't seem like a big enough deal to somehow avoid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems a bit weird for reading, but ok.
Fixes #304.
Fixes #316.
Also updated other packages.