-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6. Handle Permission Denied #42
Comments
Sorry can you provide links to the relevant page on the codelab or the specific section - I don't know what you are referring to. |
Hi Matt,
On this page
<https://codelabs.developers.google.com/codelabs/push-notifications/index.html?index=..%2F..%2Fpwa-roadshow#5>,
the function updateBtn has pushButton.disabled set to false. If we set it
to false, it interferes with the disabling of the button as it re-enables
the disable button on denying the permission, but when we comment it out,
and start afresh, the result is that the "enable" button gets disabled.
…On Wed, May 3, 2017 at 3:56 AM, Matt Gaunt ***@***.***> wrote:
Sorry can you provide links to the relevant page on the codelab or the
specific section - I don't know what you are referring to.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#42 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACSXTJvvqrUCQ_GlNfQjtTBELgWFhJtaks5r162RgaJpZM4NOJCm>
.
|
hhmmm can you give me some reproduction steps? The button should be disabled by the notification permission check
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the titled part of the codelab, should not the following code line towards the end of the function updateBtn should be removed as it otherwise turns the button ON back?
pushButton.disabled = false;
The text was updated successfully, but these errors were encountered: