Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for shared workers #42

Merged
merged 2 commits into from
Feb 21, 2020
Merged

Conversation

stutrek
Copy link
Contributor

@stutrek stutrek commented Sep 17, 2019

Title sums it up. This adds support for SharedWorker. The API is the same. Tests were added too.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@stutrek
Copy link
Contributor Author

stutrek commented Sep 17, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@stutrek stutrek mentioned this pull request Sep 17, 2019
@stutrek
Copy link
Contributor Author

stutrek commented Sep 24, 2019

@developit any chance you could take a look? Thanks.

@lasseborly
Copy link

This would be great to have merged @developit 👍

@skmvasu
Copy link

skmvasu commented Feb 11, 2020

Any plans to merge this? @developit Happy to help incase there is an issue and needs to be fixed. This will help us out in a few projects

skmvasu added a commit to skmvasu/worker-plugin that referenced this pull request Feb 12, 2020
- Copied from GoogleChromeLabs#42 since it's not merged.
Copy link
Collaborator

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Sorry I took so long to merge your PR!

@developit developit merged commit 61def08 into GoogleChromeLabs:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants