Add interceptor to inject remote address to non-ok status discription #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
============================================
- Coverage 81.54% 81.45% -0.10%
Complexity 2016 2016
============================================
Files 134 134
Lines 8877 8890 +13
Branches 1043 1043
============================================
+ Hits 7239 7241 +2
- Misses 1206 1218 +12
+ Partials 432 431 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hongyegong
reviewed
Sep 14, 2020
gcsio/src/main/java/com/google/cloud/hadoop/gcsio/GoogleCloudStorageGrpcWriteChannel.java
Show resolved
Hide resolved
gcsio/src/main/java/com/google/cloud/hadoop/gcsio/StorageStubProvider.java
Show resolved
Hide resolved
|
Thanks! This would be helpful to nail the backend! |
hongyegong
approved these changes
Sep 16, 2020
medb
pushed a commit
that referenced
this pull request
Sep 18, 2020
hongyegong
added a commit
to hongyegong/bigdata-interop
that referenced
this pull request
Oct 13, 2020
…cription (GoogleCloudDataproc#441)" This reverts commit 815e773.
mayanks
pushed a commit
to mayanks/hadoop-connectors
that referenced
this pull request
Aug 3, 2022
mayanks
pushed a commit
to mayanks/hadoop-connectors
that referenced
this pull request
Aug 3, 2022
GoogleCloudDataproc#471) * Revert "Add interceptor to inject remote address to non-ok status discription (GoogleCloudDataproc#441)" This reverts commit 815e773.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For debugging purposes, when client receives non-ok status, we want to know the remote peer address.
To achieve this, we need add additional client interceptor to introspect the remote address before error got thrown out, and also inject the address string into the status description.
+cc @veblush