Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add interceptor to inject remote address to non-ok status dis… #471

Merged
merged 2 commits into from
Oct 13, 2020

Conversation

hongyegong
Copy link
Contributor

…cription (#441)"

This reverts commit 815e773.

The remote_addr is now included in the server log so the redundant logging is not needed. Plus this appears to be the culprit that causes the TestDFSIO jobs to be hanging.

@google-cla google-cla bot added the cla: yes label Oct 13, 2020
@hongyegong hongyegong requested a review from medb October 13, 2020 03:52
@medb
Copy link
Contributor

medb commented Oct 13, 2020

/gcbrun

@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #471 into master will increase coverage by 0.07%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #471      +/-   ##
============================================
+ Coverage     81.93%   82.00%   +0.07%     
  Complexity     2004     2004              
============================================
  Files           135      135              
  Lines          8905     8892      -13     
  Branches       1052     1052              
============================================
- Hits           7296     7292       -4     
+ Misses         1176     1167       -9     
  Partials        433      433              
Flag Coverage Δ Complexity Δ
#hadoop2integrationtest 59.26% <0.00%> (+0.34%) 1407.00 <0.00> (+9.00)
#hadoop2unittest 70.07% <66.66%> (+0.07%) 1688.00 <0.00> (-1.00) ⬆️
#hadoop3integrationtest 58.90% <0.00%> (+0.06%) 1399.00 <0.00> (+1.00)
#hadoop3unittest 70.07% <66.66%> (+0.07%) 1692.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...google/cloud/hadoop/gcsio/StorageStubProvider.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...doop/gcsio/GoogleCloudStorageGrpcWriteChannel.java 88.33% <50.00%> (-0.37%) 9.00 <0.00> (ø)
...adoop/gcsio/GoogleCloudStorageGrpcReadChannel.java 86.15% <100.00%> (-0.15%) 45.00 <0.00> (ø)
...gle/cloud/hadoop/gcsio/GoogleCloudStorageImpl.java 87.27% <0.00%> (-0.42%) 184.00% <0.00%> (-1.00%)
...loud/hadoop/gcsio/cooplock/CoopLockRecordsDao.java 88.41% <0.00%> (+1.21%) 35.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f1fd46...c569260. Read the comment docs.

@hongyegong hongyegong merged commit a580adf into GoogleCloudDataproc:master Oct 13, 2020
hongyegong added a commit that referenced this pull request Nov 6, 2020
#471)

* Revert "Add interceptor to inject remote address to non-ok status discription (#441)"

This reverts commit 815e773.
mayanks pushed a commit to mayanks/hadoop-connectors that referenced this pull request Aug 3, 2022
GoogleCloudDataproc#471)

* Revert "Add interceptor to inject remote address to non-ok status discription (GoogleCloudDataproc#441)"

This reverts commit 815e773.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants