Pseudo column support #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
esert-g
force-pushed
the
partitioned_table_but_no_push_down
branch
from
72abdfb
to
9960312
Compare
|
/gcbrun |
davidrabinowitz
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If queried BQ table is ingestion time partitioned, schema of the table is modified with the additions of top level _PARTITIONTIME and _PARTITIONDATE fields. This introduces a slight behavior change for select * queries (i.e. the two new pseudo columns are returned on top of regular schema). This can't be avoided at the moment because there isn't a way to differentiate queries within connector as far as I can tell. We also discovered a case where some of the array filters are erroneously rejected by bq storage api. We will have to disable their pushdown until it is fixed.