Fix parallelism: add missing groupby, move batching out of Neo4j writer #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbiville
force-pushed
the
neo4j/group_by
branch
from
aa2de67
to
256ada5
Compare
fbiville
changed the title
fbiville
force-pushed
the
neo4j/group_by
branch
from
256ada5
to
1bf6f65
Compare
ali-ince
approved these changes
Mar 7, 2024
liferoad
reviewed
Mar 8, 2024
...neo4j/src/main/java/com/google/cloud/teleport/v2/neo4j/transforms/Neo4jBlockingUnwindFn.java
Outdated
Show resolved
Hide resolved
liferoad
previously approved these changes
Mar 8, 2024
liferoad
approved these changes
Mar 11, 2024
liferoad
added
the
Google LGTM
copybara-service
bot
merged commit 180f122
into
GoogleCloudPlatform:main
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.