Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BULK] Add basic IT for bulk #1584

Merged
merged 3 commits into from
May 28, 2024
Merged

Conversation

Deep1998
Copy link
Contributor

No description provided.

@Deep1998 Deep1998 requested a review from a team as a code owner May 21, 2024 12:42
@Deep1998 Deep1998 requested review from asthamohta and VardhanThigle and removed request for a team May 21, 2024 12:42
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.24%. Comparing base (8a3575c) to head (b7220d8).
Report is 4 commits behind head on main.

Current head b7220d8 differs from pull request most recent head 6ca7f1f

Please upload reports for the commit 6ca7f1f to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1584      +/-   ##
============================================
+ Coverage     41.20%   47.24%   +6.04%     
+ Complexity     2875      451    -2424     
============================================
  Files           745      203     -542     
  Lines         43572    10130   -33442     
  Branches       4635      964    -3671     
============================================
- Hits          17952     4786   -13166     
+ Misses        24105     5022   -19083     
+ Partials       1515      322    -1193     
Components Coverage Δ
spanner-templates 80.28% <ø> (+19.45%) ⬆️
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration 75.58% <ø> (+1.94%) ⬆️
spanner-live-reverse-replication 75.58% <ø> (+26.91%) ⬆️
spanner-bulk-migration 80.32% <ø> (-1.18%) ⬇️

see 577 files with indirect coverage changes

@Deep1998 Deep1998 force-pushed the its branch 3 times, most recently from 9908894 to f1b4b22 Compare May 23, 2024 06:16
@manitgupta
Copy link
Member

Can we document the Bulk migration CUJs in parallel as well so that we are clear on what CUJs we plan to cover via ITs similar to live and reverse replication -

Live
https://g3doc.corp.google.com/third_party/harbourbridge/g3doc/testing/integration-testing/forward-migration-it.md?cl=head

Reverse
https://critique.corp.google.com/cl/636253544

@Deep1998 Deep1998 force-pushed the its branch 7 times, most recently from 8ecec7d to 428b1f1 Compare May 24, 2024 05:41
@Deep1998 Deep1998 force-pushed the its branch 2 times, most recently from 2265b1a to b7220d8 Compare May 27, 2024 09:10
@Deep1998
Copy link
Contributor Author

Can we document the Bulk migration CUJs in parallel as well so that we are clear on what CUJs we plan to cover via ITs similar to live and reverse replication -

Live https://g3doc.corp.google.com/third_party/harbourbridge/g3doc/testing/integration-testing/forward-migration-it.md?cl=head

Reverse https://critique.corp.google.com/cl/636253544

Yes they are currently documented in this doc. Will raise a cl for a g3doc once finalised.

Copy link
Contributor

@bharadwaj-aditya bharadwaj-aditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VardhanThigle VardhanThigle added the Google LGTM Approval of a pull request to be merged into the repository label May 28, 2024
@copybara-service copybara-service bot merged commit f807c69 into GoogleCloudPlatform:main May 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Google LGTM Approval of a pull request to be merged into the repository size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants