Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate Version into a single constant #2

Closed
markmandel opened this issue Dec 7, 2017 · 0 comments
Closed

Consolidate Version into a single constant #2

markmandel opened this issue Dec 7, 2017 · 0 comments
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! kind/cleanup Refactoring code, fixing up documentation, etc kind/design Proposal discussing new features / fixes and how they should be implemented
Milestone
0.1

Comments

@markmandel
Copy link
Member

There are several instances of a Version around the go code. It would be good to refactor this into a single constant that is shared across each binary (controller, sidecar).
@markmandel markmandel added good first issue These are great first issues. If you are looking for a place to start, start here! kind/cleanup Refactoring code, fixing up documentation, etc kind/design Proposal discussing new features / fixes and how they should be implemented labels Dec 7, 2017
@markmandel markmandel mentioned this issue Dec 11, 2017
Closed
2 tasks
markmandel added a commit that referenced this issue Dec 13, 2017
@markmandel
Consolidate the Version constant
b4d29c3 
This puts the Version in a single place,
which is a setup for #21, and means there will
always be constant version information across
all the moving pieces.

Closes #2
markmandel added a commit that referenced this issue Dec 13, 2017
@markmandel
Consolidate the Version constant
57db13f 
This puts the Version in a single place,
which is a setup for #21, and means there will
always be constant version information across
all the moving pieces.

Closes #2
@markmandel markmandel mentioned this issue Dec 13, 2017
Merged
@alexandrem alexandrem mentioned this issue Mar 26, 2018
Closed
@markmandel markmandel mentioned this issue May 22, 2018
Merged
@markmandel markmandel added this to the 0.1 milestone May 23, 2018
@markmandel markmandel mentioned this issue Jul 19, 2018
Closed
@victor-prodan victor-prodan mentioned this issue Jul 19, 2018
Closed
@markmandel markmandel mentioned this issue Sep 1, 2018
Closed
@markmandel markmandel mentioned this issue Oct 2, 2018
Closed
@markmandel markmandel mentioned this issue Feb 18, 2019
Closed
@akremsa akremsa mentioned this issue Apr 9, 2020
Merged
@satishdsb satishdsb mentioned this issue Sep 21, 2022
Closed
zmerlynn added a commit to zmerlynn/agones that referenced this issue Apr 24, 2023
@zmerlynn
require.NoError in fleet tests instead of continuing
a329573 
When the fleet tests flake, they take out the rest of the test suite:

```
Step googleforgames#24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step googleforgames#2 - "e2e-stable": VERBOSE: --- FAIL: TestFleetScaleUpAllocateEditAndScaleDownToZero (163.39s)
Step googleforgames#24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step googleforgames#2 - "e2e-stable": VERBOSE: panic: runtime error: index out of range [0] with length 0 [recovered]
Step googleforgames#24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step googleforgames#2 - "e2e-stable": VERBOSE:     panic: runtime error: index out of range [0] with length 0
```

Looking at this file, it's easy to see why: if there's every an error
from any of these asserts, we just continue with the test and assume
the fleet is valid. But it's not.
zmerlynn added a commit to zmerlynn/agones that referenced this issue Apr 24, 2023
@zmerlynn
require.NoError in fleet tests instead of continuing
376523a 
When the fleet tests flake, they take out the rest of the test suite:

```
Step googleforgames#24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step googleforgames#2 - "e2e-stable": VERBOSE: --- FAIL: TestFleetScaleUpAllocateEditAndScaleDownToZero (163.39s)
Step googleforgames#24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step googleforgames#2 - "e2e-stable": VERBOSE: panic: runtime error: index out of range [0] with length 0 [recovered]
Step googleforgames#24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step googleforgames#2 - "e2e-stable": VERBOSE:     panic: runtime error: index out of range [0] with length 0
```

Looking at this file, it's easy to see why: if there's every an error
from any of these asserts, we just continue with the test and assume
the fleet is valid. But it's not.
zmerlynn added a commit that referenced this issue Apr 24, 2023
@zmerlynn
require.NoError in fleet tests instead of continuing (#3124)
b22ec70 
* require.NoError in fleet tests instead of continuing

When the fleet tests flake, they take out the rest of the test suite:

```
Step #24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step #2 - "e2e-stable": VERBOSE: --- FAIL: TestFleetScaleUpAllocateEditAndScaleDownToZero (163.39s)
Step #24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step #2 - "e2e-stable": VERBOSE: panic: runtime error: index out of range [0] with length 0 [recovered]
Step #24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step #2 - "e2e-stable": VERBOSE:     panic: runtime error: index out of range [0] with length 0
```

Looking at this file, it's easy to see why: if there's every an error
from any of these asserts, we just continue with the test and assume
the fleet is valid. But it's not.
@Kalaiselvi84 Kalaiselvi84 mentioned this issue Jul 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! kind/cleanup Refactoring code, fixing up documentation, etc kind/design Proposal discussing new features / fixes and how they should be implemented
Projects
None yet
Milestone
0.1
Development

No branches or pull requests
1 participant
@markmandel