Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unhealthy message to sdk #302

Closed
nikibobi opened this issue Jul 21, 2018 · 6 comments
Closed

Add unhealthy message to sdk #302

nikibobi opened this issue Jul 21, 2018 · 6 comments
Labels
wontfix Sorry, but we're not going to do that.

Comments

@nikibobi
Copy link
Contributor

Currently game servers send health checks every few seconds and if they stop they become unhealthy. I think an unhealthy method should be added for times when the game server knows it's in a bad state. It should be sent once and the server marked unhealthy.

@markmandel
Copy link
Member

Interesting idea! Curious though - if you know you are unhealthy, why not call Shutdown() and self terminate?

At least at this stage, that will end up happening anyway. Or are you looking to use the Unhealthy state for something?

@nikibobi
Copy link
Contributor Author

With unhealthy you know something has happened and maybe should investigate. I think shutdown should be used when a match is over and the game ended normally.

@markmandel
Copy link
Member

That's a fair point - but that would mean Unhealthy would show up in the resource state, and the event list - which would only be persistent until the resource got deleted - so not that long? At which point, it's gone.

You may be better off just doing some of your own process logging before Shutting something down, and alerting/introspecting/analysing on the aggregated logs?

Curious - is there precedent for this anywhere else? (i.e. Gamelift, i3d, etc?).

I'm also thinking about visualisations etc - and if you mark it as Unhealthy, it could definitely show up there.

Also curious - what sort of situations would you see this happening in -- wherein you know the gameserver is no longer healthy?

@nikibobi
Copy link
Contributor Author

I don't have a specific use case and I you are right that the resource will get deleted right after. Visualisations would be great.

@cyriltovena
Copy link
Collaborator

@nikibobi Are we happy to close this one ? I also leaning toward metrics on logging to alert on gameserver failure as this will last longer than kubernetes state.

@nikibobi
Copy link
Contributor Author

nikibobi commented Jan 4, 2019

@Kuqd yes, you are right that a more persistent solution is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix Sorry, but we're not going to do that.
Projects
None yet
Development

No branches or pull requests

3 participants