minikube-test-cluster needed the ensure-build-image dependency
#194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Make target `minikube-test-cluster` didn't have the `ensure-build-image` dependency, so if you started a cluster, without having the image already available, the creation of the minikube cluster would fail.
markmandel
added
kind/bug
|
Build Succeeded 👏 Build Id: 53ed3071-631c-400c-a38e-a3b48c99b335 The following development artifacts have been built, and will exist for the next 30 days:
|
cyriltovena
approved these changes
May 2, 2018
|
Build Succeeded 👏 Build Id: ef492ee2-4b5a-4655-9219-7f495ac147f3 The following development artifacts have been built, and will exist for the next 30 days:
|
|
Build Succeeded 👏 Build Id: 1c56d685-42cc-4116-b3c0-543a3c1c6a4e The following development artifacts have been built, and will exist for the next 30 days:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Make target
minikube-test-clusterdidn't have theensure-build-imagedependency, so if you started a cluster, without having the image already available, the creation of the minikube cluster would fail.