Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added resource limits to gameserver.yaml and changed to generateName: #496

Merged
merged 2 commits into from
Jan 23, 2019
Merged

added resource limits to gameserver.yaml and changed to generateName: #496

merged 2 commits into from
Jan 23, 2019

Conversation

jkowalski
Copy link
Contributor

this allows easy ad-hoc creation of multiple game servers and facilitates dense load testing

@jkowalski
added resource limits to gameserver.yaml and changed to name: to gene…
29d0636 
…rateName:, this allows easy ad-hoc creation of multiple game servers and facilitates dense load testing
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 99765961-f084-4bfb-8fed-505390a6de1b

The following development artifacts have been built, and will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/496/head:pr_496 && git checkout pr_496
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-29d0636

markmandel
markmandel approved these changes Jan 23, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/examples Examples. Usually found in the `examples` directory labels Jan 23, 2019
@markmandel markmandel added this to the 0.8.0 milestone Jan 23, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: fc026fa4-6a24-477e-99c8-7f987b09549a

The following development artifacts have been built, and will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/496/head:pr_496 && git checkout pr_496
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-d88471b

@markmandel markmandel merged commit c62be56 into googleforgames:master Jan 23, 2019
@jkowalski jkowalski deleted the gameserver-yaml branch January 23, 2019 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
area/examples Examples. Usually found in the `examples` directory kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jkowalski @agones-bot @markmandel