add canonical service controller to 1.6

[PatchworkGuilt]

As we outlined in go/canonical-service-asm-build, this adds the canonical service controller to the ASM distro release.

To save your time during review: this is the exact same controller.yaml file copy/pasted across 4 folders.

[elfinhe]

How do we test canonical services? Or it is done manually?

[PatchworkGuilt]

@elfinhe Integration tests are run as part of the image build process. They can be found here: https://team.git.corp.google.com/csm-ux-eng/canonical-service/+/refs/heads/master/controllers/

[elfinhe]

Some general comments about folder structure:

1. in asm/ asm-citadel/: just move canonical-service 1 level up. cluster is used for defining cluster infra.
2. Also need to update asm-patch/resources/kustomization.yaml and asm-patch-citadel/resources/kustomization.yaml to include canonical into the resources of kustomize.

[PatchworkGuilt]

Thank you, I've cleaned up the folder structure and added it to those two kustomization.yaml files.

[yangminzhu]

Mostly looks good, only some small comments, thanks!

[elfinhe]

LGTM! but the latest commit mentioned my commit, which commit is that?

[PatchworkGuilt]

Unclear how, but somehow my attempts to rebase my branch to include the latest changes you made to 'release-1.60-asm' wound up including all your changes in my branch, which made a huge mess (https://github.com/GoogleCloudPlatform/anthos-service-mesh-packages/tree/release-1.6-asm). I did a 'git reset' and rebuilt my changes fresh to bail myself out.

[yangminzhu]

thank you!

[michaelsun3]

what is the canonical-service-controller for?