Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Node 10 to the LTS version in Yarn #475

Closed
wants to merge 1 commit into from

Conversation

charud
Copy link

@charud charud commented Apr 8, 2019

Bumps Node 10.10.0 to 10.15.3 (LTS)

Bumps Node 10.10.0 to 10.15.3 (LTS)
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no CLA does not look good :( label Apr 8, 2019
@charud
Copy link
Author

charud commented Apr 8, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes CLA looks good and removed cla: no CLA does not look good :( labels Apr 8, 2019
@elizabeth-dev
Copy link

It seems that this Cloud Builder image is deprecated. I was writing a PR to add 11.x and 12.x versions when I saw this. Bad news, it would be really useful for saving some Cloud Build seconds, instead of pulling official Node.js image.

@mehdime
Copy link

mehdime commented Dec 5, 2019

Are there any guidelines on how to contribute updated versions of these images? Having a more recent version of Node available would be handy but that PR seems to have been stuck here for a few months now.

@elizabeth-dev
Copy link

@mehdime I just forked the repo (privately), and built a custom image in my own container registry namespace adding the desired versions.

@bendory
Copy link
Member

bendory commented May 15, 2020

closing as obsolete; reference #322

@bendory bendory closed this May 15, 2020
@bendory bendory self-assigned this May 15, 2020
@GoogleCloudPlatform GoogleCloudPlatform locked as resolved and limited conversation to collaborators May 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes CLA looks good
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants