Don't set environment in resetEditorFrom() #739
Conversation
|
LGTM. Remind me why we're storing it in the configuration again? |
|
Sure - that was for deserialization - see #734 |
|
oh right. You can't determine the environment at deserialization time. We should add a comment explaining why it's there. |
|
How can |
|
@chanseokoh When you create a new deployment config for the first time, resetEditorFrom() is invoked with a configuration who's values are all null. |
|
@patflynn I added a comment explanation on the member variable in the deployment configuration. |
|
Thanks! On Fri, Jun 17, 2016 at 4:20 PM, Etan Shaul notifications@github.com
|
|
@chanseokoh let me know if you are ok with this. I admit I was surprised by the behavior myself. |
|
🚢 |
…ij into upgrade-ij-gradleplugin * 'master' of github.com:GoogleCloudPlatform/gcloud-intellij: (30 commits) IJ build version (#762) Update tracking api clients (#760) Update CHANGELOG.md (#759) Experimenting with new tracking API (#752) Release v0.9.6 beta (#758) Service lookup should use interface (#757) Release v0.9.5 beta (#756) Identify and properly label all compat projects (#753) Follow the convention /virtual/eventType/eventName (#754) Updates our app-tools-lib-for-java to the new name and released version. (#755) Retrieve plugin name from PluginInfoService (#743) Track deploy and stop task execution events (#750) Create pre-build task for app engine artifact sources (#749) Update changelog release date (#747) Restructure metrics event actions (#744) Don't show custom deployment options when flex compat (#745) Don't set environment in resetEditorFrom() (#739) Sync up with app-tools - remove setting of gsUtil (#737) Update changelog for next release (#735) Save and load artifact deployment source types (#734) ...
fixes #738
Since we are explicitly passing in the environment to the Editor constructor, there is no need to reset it from the configuration.