Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When cloning a Custom Sample it appears the name is used as the path #430

Closed
viglesiasce opened this issue May 21, 2021 · 3 comments
Closed
Assignees
Labels
area/samples kind/bug Something isn't working priority/p2 Needs action later
Milestone

Comments

@viglesiasce
Copy link

Version information

Cloud Code Extension version: latest

VSCode version: latest

OS: mac m1

Managed Dependencies: on
Cloud SDK Version: 341.0.0
Skaffold Version: v1.23.0
Minikube Version: 1.20.0
Description:

When choosing a folder to put the cloned sample the UI uses a suffix that maps to the name ("Bank of Anthos") field of the entry in .cctemplate rather than the path ("bank-of-anthos")

Repro step:

  1. Add this as a new Custom Sample repo: https://github.com/viglesiasce/cloud-code-custom-templates-example-2
  2. Create a new app with the Bank of Anthos sample
@sivakku sivakku added area/samples kind/bug Something isn't working priority/p2 Needs action later labels May 21, 2021
@sivakku sivakku added this to the Backlog milestone May 21, 2021
@vjocw
Copy link
Contributor

vjocw commented May 21, 2021

Hey @viglesiasce

Thank you for the report.

I want to clarify a detail. Are you talking about the Save As field of the dialog being pre-populated?:
image

@viglesiasce
Copy link
Author

viglesiasce commented May 21, 2021 via email

@sivakku
Copy link
Contributor

sivakku commented May 21, 2021

This needs to be consistent with the what we do with our regular sample, sanitizing to have dashes and lower cases, The registry name doesn't like Upper case as well.

image

@sivakku sivakku closed this as completed May 21, 2021
@sivakku sivakku reopened this May 21, 2021
@vjocw vjocw closed this as completed Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/samples kind/bug Something isn't working priority/p2 Needs action later
Projects
None yet
Development

No branches or pull requests

3 participants