Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed README and test for DNS module #1990

Merged
merged 2 commits into from Jan 19, 2024
Merged

Fixed README and test for DNS module #1990

merged 2 commits into from Jan 19, 2024

Conversation

apichick
Copy link
Collaborator

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@apichick apichick requested a review from wiktorn January 18, 2024 18:06
wiktorn
wiktorn reviewed Jan 18, 2024
View reviewed changes
modules/dns/README.md Outdated Show resolved Hide resolved
@apichick apichick merged commit 1ba8298 into GoogleCloudPlatform:master Jan 19, 2024
9 checks passed
@ludoo ludoo changed the title Fixed README and test for dns module Fixed README and test for DNS module Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiktorn wiktorn wiktorn left review comments

@juliocc juliocc juliocc approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@apichick @juliocc @wiktorn @ludoo