Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed README and test for DNS module #1990

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Fixed README and test for DNS module #1990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
228a4a8
Fixed README and test for dns module
apichick Jan 18, 2024
09176fe
Fix typo in example
wiktorn Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/dns/README.md
View file
Open in desktop
Expand Up @@ -93,7 +93,7 @@ module "private-dns" {
{ location = "europe-west1", health_checked_targets = [
{
load_balancer_type = "globalL7ilb",
ip_address = "gil7-forwarding-rule-a",
ip_address = "10.10.2.3",
port = "80",
ip_protocol = "tcp",
network_url = var.vpc.self_link
Expand All @@ -103,7 +103,7 @@ module "private-dns" {
{ location = "europe-west2", health_checked_targets = [
{
load_balancer_type = "globalL7ilb",
ip_address = "gil7-forwarding-rule-b",
ip_address = "10.10.3.3",
port = "80",
ip_protocol = "tcp",
network_url = var.vpc.self_link
Expand Down
4 changes: 2 additions & 2 deletions tests/modules/dns/examples/routing-policies.yaml
View file
Open in desktop
Expand Up @@ -66,7 +66,7 @@ values:
geo:
- health_checked_targets:
- internal_load_balancers:
- ip_address: gil7-forwarding-rule-a
- ip_address: 10.10.2.3
ip_protocol: tcp
load_balancer_type: globalL7ilb
network_url: projects/xxx/global/networks/aaa
Expand All @@ -77,7 +77,7 @@ values:
rrdatas: null
- health_checked_targets:
- internal_load_balancers:
- ip_address: gil7-forwarding-rule-b
- ip_address: 10.10.3.3
ip_protocol: tcp
load_balancer_type: globalL7ilb
network_url: projects/xxx/global/networks/aaa
Expand Down