Add support for billing budgets to project factory #2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktorn
approved these changes
Feb 27, 2024
Co-authored-by: Wiktor Niesiobędzki <wiktorn@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for billing budgets to the project factory.
The approach is consistent with how budgets are designed, where there's no 1:1 relationship between a budget and a project, but budgets are meant to be defined for groups of projects identified by one or more common ancestors (organization or folder), and filtered via a list of specific projects if needed.
This design accommodates the 1:1 scenario of course, but is really meant to support budget definition for groups of projects belonging to a team or service, or even for a whole organization. The naive approach we followed in the previous project factory version which is also from time to time submitted via PRs, of having a forced 1:1 mapping between a project and a billing account, is too narrow and prevents using budgets as they are designed to be used.