Maven version to 3.6.1 #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elharo
reviewed
Jul 29, 2019
| @@ -41,7 +41,7 @@ | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
| <guava.version>28.0-jre</guava.version> | |||
| <resolver.version>1.4.0</resolver.version> | |||
There was a problem hiding this comment.
It looks like this PR would downgrade our resolver version to 1.3.3. If so, I'm not sure we want to do that.
There was a problem hiding this comment.
I see maven-resolver-api 1.4.0 in its dependency tree https://gist.github.com/suztomo/f3a99fa9c285c00552c751911e342b59.
Both this pom's parent (dependency-parent) and org.apache.maven:maven:3.6.1 try to set maven-resolver-api version. Seems the former wins.
There was a problem hiding this comment.
I just created #810 to clarify maven-related dependencies should have provided scope, because these dependencies are already there when Maven runs an enforcer rule.
elharo
approved these changes
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #803 (ClassNotFoundError due to dependency conflict)
Initially I was thinking to fix it by multiple exclusion elements
(commit), but leveraging Maven's BOM for version 3.6.1 is more straightforward to control the version of plexus-util in the transitive dependency.