New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maven version to 3.6.1 #802
Merged
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5d682f8
Maven version 3.6.1
suztomo a304f9b
Check maven version
suztomo 46ed30b
useSystemClassLoader?
suztomo da0a77f
Exclude old plexus-utils dependency
suztomo ef5c4af
Exclusion for plexus-util
suztomo 8a3a7bf
Using maven BOM to control plexus-util version
suztomo 6bf73a6
Added comment
suztomo a925840
Merge remote-tracking branch 'origin/master' into maven_version
suztomo 6e8da00
Merge remote-tracking branch 'origin/master' into maven_version
suztomo e152b86
Merge branch 'master' into maven_version
suztomo 0a5d36b
Merge branch 'master' into maven_version
suztomo 02c6a0e
Merge branch 'master' into maven_version
suztomo File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this PR would downgrade our resolver version to 1.3.3. If so, I'm not sure we want to do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see maven-resolver-api 1.4.0 in its dependency tree https://gist.github.com/suztomo/f3a99fa9c285c00552c751911e342b59.
Both this pom's parent (dependency-parent) and
org.apache.maven:maven:3.6.1
try to set maven-resolver-api version. Seems the former wins.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just created #810 to clarify maven-related dependencies should have provided scope, because these dependencies are already there when Maven runs an enforcer rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created #813
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
813 merged.